Retain struct's type in partial and pick helpers #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors partial helper to more directly reflect its internal logic including schema shorthand usage.
|
@ianstormtaylor Are there any blockers? This would be a really useful fix. |
|
@ianstormtaylor Same here, this would be super useful if there are no issues with the PR. Thanks! |
|
@dlindenkreuz @kevcao-certik this will be landing in the next release! I will be helping Ian with the maintenance of Superstruct from now on, so as soon as I get publish rights on npm you will be able to (finally) use this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #829