Respect refiner in dynamic and lazy
#966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything that I can help to get this PR in? |
|
@sammkj Unfortunately, I don't think so. @ianstormtaylor hasn't been active in this repo (or at all, looking at his GitHub profile) since a few days before I opened this PR. At work, we are using a patched version of |
|
Sorry for the delay, thanks @Gelio! |
|
No worries, thanks for taking a look and merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the refiners being previously ignored in the structs returned by
lazyanddynamicutilities.I have added 2 new test cases that prove the refiners work now.
Fixes #830