Merge pull request #422 from ianwalter/fix-skipped-log

Fix #420: Dont show skipped tests when running with the --failed flag

.github/workflows/ci.yml

@@ -28,10 +28,10 @@ jobs:
       - name: Lint
         run: yarn lint
       - name: Test bff
-        run: cd packages/bff; yarn test:ci
+        run: cd packages/bff; yarn test.ci
       # TODO:
       # - name: Test bff-webdriver
-      #   run: npm run test:webdriver
+      #   run: npm run test.webdriver
   playwright:
     runs-on: ubuntu-latest
     container:
@@ -43,4 +43,4 @@ jobs:
       - name: Install
         run: yarn
       - name: Test bff
-        run: yarn test:playwright
+        run: yarn test.playwright

package.json

@@ -5,12 +5,12 @@
   "license": "SEE LICENSE IN LICENSE",
   "scripts": {
     "lint": "eslit",
-    "test:bff": "npm run --prefix packages/bff test:ci",
-    "test:webdriver": "npm run --prefix packages/bff-webdriver test",
-    "test:puppeteer": "npm run --prefix packages/bff-puppeteer test",
-    "test:playwright": "npm run --prefix packages/bff-playwright test",
-    "docs:dev": "vuepress dev docs",
-    "docs:build": "vuepress build docs"
+    "test.bff": "npm run --prefix packages/bff test.ci",
+    "test.webdriver": "npm run --prefix packages/bff-webdriver test",
+    "test.puppeteer": "npm run --prefix packages/bff-puppeteer test",
+    "test.playwright": "npm run --prefix packages/bff-playwright test",
+    "docs.dev": "vuepress dev docs",
+    "docs.build": "vuepress build docs"
   },
   "workspaces": [
     "packages/*"

packages/bff/index.js

@@ -192,7 +192,7 @@ export async function run (config) {
           snapshotState.markSnapshotsAsCheckedForTest(test.name)
 
           const skipViaOnly = hasOnly && !test.only
-          if (skipViaOnly || test.skip) {
+          if ((skipViaOnly || test.skip) && !failed) {
             // Output the test name and increment the skip count to remind
             // the user that some tests are being explicitly skipped.
             const msg = `${context.testsRun + 1}. ${test.name}`

packages/bff/package.json

@@ -7,8 +7,8 @@
   "module": "index.js",
   "scripts": {
     "test": "./cli.js",
-    "test:ci": "./cli.js -V tests/bff.js",
-    "test:out": "./cli.js tests/stdout.js | wc -c"
+    "test.ci": "./cli.js -V tests/bff.js",
+    "test.out": "./cli.js tests/stdout.js | wc -c"
   },
   "bin": {
     "bff": "cli.js"