Don't create a reporter if no streams were provided. Addresses hapijs…

…#534
ianwsperber · Nov 18, 2016 · 18780d3 · 18780d3
1 parent dfe7912
commit 18780d3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/monitor.js b/lib/monitor.js
@@ -92,6 +92,9 @@ class Monitor {
     start(callback) {
 
         internals.forOwn(this.settings.reporters, (reporterName, streamsSpec) => {
+            if (!streamsSpec.length) {
+                return;
+            }
 
             const streamObjs = [];
             for (let i = 0; i < streamsSpec.length; ++i) {

diff --git a/test/monitor.js b/test/monitor.js
@@ -245,6 +245,24 @@ describe('Monitor', () => {
 
             done();
         });
+
+        it('does not create a reporter if it has no streams', { plan: 2 }, (done) => {
+
+            const monitor = internals.monitorFactory(new Hapi.Server(), {
+                reporters: {
+                    foo: []
+                }
+            });
+
+            monitor.start((error) => {
+
+                expect(error).to.not.exist();
+
+                expect(monitor._reporters).to.have.length(0);
+
+                done();
+            });
+        });
     });
 
     describe('push()', () => {