Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Mouse follows focused windows" shouldn't move the mouse while the user is moving the mouse #1006

Open
minego opened this issue Apr 15, 2020 · 3 comments · Fixed by #1013
Open

"Mouse follows focused windows" shouldn't move the mouse while the user is moving the mouse #1006

minego opened this issue Apr 15, 2020 · 3 comments · Fixed by #1013

Comments

@minego
Copy link

minego commented Apr 15, 2020

Focusing a window with the mouse (either by clicking or using "Focus follows mouse") causes the mouse to jump to the newly focused window. This is not needed since the mouse is already over the newly focused window, and conflicts with the user's actions.
@minego
Copy link
Author

minego commented Apr 15, 2020

btw, thank you very much for fixing "Focus follows mouse" in the last update. I had missed it!

rickyz added a commit to rickyz/Amethyst that referenced this issue May 4, 2020
@rickyz
Improvements to focus follows mouse/mouse follows focus.
f39ff64 
 - Previously, mouse-follows-focus was only triggered for when Amethyst
   itself focuses a window. This made it difficult to windows which close
   upon losing focus, as moving the mouse to the window would cause it to
   lose focus. Fix this by triggering mouse-follows-focus on all window
   focus events. Also trigger on window activations and reflows so that
   the mouse moves over the active window.

 - Disable mouse-follows-focus for windows recently focused via
   focus-follows-mouse. Otherwise, when both mout-follows-focus and
   focus-follows-mouse are enabled, moving the mouse over the edge of a
   window will immediately teleport the mouse to the center of the
   window.

Fixes ianyh#1006.
rickyz added a commit to rickyz/Amethyst that referenced this issue May 4, 2020
@rickyz
Improvements to focus follows mouse/mouse follows focus.
5232d36 
 - Previously, mouse-follows-focus was only triggered for when Amethyst
   itself focuses a window. This made it difficult to windows which close
   upon losing focus, as moving the mouse to the window would cause it to
   lose focus. Fix this by triggering mouse-follows-focus on all window
   focus events. Also trigger on window activations and reflows so that
   the mouse moves over the active window.

 - Disable mouse-follows-focus for windows recently focused via
   focus-follows-mouse. Otherwise, when both mout-follows-focus and
   focus-follows-mouse are enabled, moving the mouse over the edge of a
   window will immediately teleport the mouse to the center of the
   window.

 - Do not move the mouse while a mouse button is pressed. The user is
   most likely dragging something between windows in that case (for
   example, moving a Chrome tab between windows).

Fixes ianyh#1006.
@rickyz rickyz mentioned this issue May 4, 2020
Merged
@ianyh
Copy link
Owner

ianyh commented Oct 9, 2020

I unfortunately had to reintroduce this. See #1060

@ianyh ianyh reopened this Oct 9, 2020
This was referenced Oct 9, 2020
Closed
Closed
@lalithsuresh
Copy link

Is there any fix/workaround for this issue on the charts? I just switched from yabai to Amethyst, and this is the only user experience difference I feel so far. (thanks for creating an awesome tool!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Focus-follows-mouse/mouse-follows-focus improvements rickyz/Amethyst
3 participants
@ianyh @lalithsuresh @minego