Fix crash in electron app when loading model #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes crashes in electron applications that use asar archiving (as seen in serenadeai#30), which is enabled by default in electron.
When using asar archiving, native dependencies such as speech-recorder are not bundled in the asar file, remaining in the separate path app.asar.unpacked.
As seen in electron/electron#6262, Electron has trouble using __dirname, as the asar bundling messes with the paths for dependencies: __dirname will resolve to a path with app.asar in it, while it should actually have app.asar.unpacked. For now, there is no fix or API for handling this on electron, so this simple replace should address the problem (which is the approach taken in the issue above).