Several improvements for non-Windows systems #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow lowercase unhyphenated `utf8` * Allow LC_CTYPE to contain language as well as encoding * Relax formatting requirements, so `foo_BAR@utf-8.quotes` or similar gets accepted as well * Handle overrides correctly, using the highest priority non-empty setting * Simplify test suite by reducing each test to one line * Fix tests since assigning null or undefined to process.env will stringify that (at least on my Node 5.3.0), instead of unsetting the variable
|
Thanks for putting this together, I've landed it in 2.0.1. |
iarna
added a commit
to npm/npm
that referenced
this pull request
Jun 24, 2016
Fix unicode dection on a number of Linux distributions. Credit: @Darkhogg Credit: @gagern Reviewed-By: @iarna PR-URL: iarna/has-unicode#3 PR-URL: iarna/has-unicode#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf8LC_CTYPEto contain language as well as encodingfoo_BAR@utf-8.quotesor similar gets accepted as wellnullorundefinedtoprocess.envwill stringify that (at least on my Node 5.3.0), instead of unsetting the variableThis fixes #2. I consider this solution superior to #3, so personally I'd say it supersedes that.