Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dev db persistence #33

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Fix/dev db persistence #33

merged 3 commits into from
Jun 7, 2023

Conversation

julianochoi
Copy link
Collaborator

@julianochoi julianochoi commented Jun 7, 2023

Description

  • Replaces devcontainer services container name to a fixed and simpler name.
  • Removes postgres data persistence
  • Fixes devcontainer creation being dependent on correct folder naming.
    • Now the devcontainer creation is independent of the workspace folder name on the host.

Related Issue

[Closes/Fixes/Resolves #[issue number]: Describe the related issue that this PR addresses.]

@julianochoi
Copy link
Collaborator Author

To whom it may concern/review:

  • clone this repository in folder with different name:
    git clone git@github.com:iaurg/42-transcendence.git test_transcendence
  • change to this branch:
    git checkout fix/dev_db_persistence
  • Build devcontainer and check if the following are correct:
    • Devcontainer has the repo files.
    • Changing a file in the devcontainer correctly changes in the host.
    • Changing a file in the host correctly changes in the devcontainer.
    • There are no persistent data in the Postgres database after restarting the Postgres container.
  • Since the persistence of Postgres was removed, you can remove the postgres folder in the root folder of the repo, if it exists.

NOTE: The folder postgres may have different ownership and may require sudo to remove.

@julianochoi julianochoi marked this pull request as ready for review June 7, 2023 02:08
@iaurg iaurg merged commit c36f0c7 into main Jun 7, 2023
1 of 2 checks passed
@iaurg iaurg deleted the fix/dev_db_persistence branch June 7, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants