Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpful error message on few arguments #49

Merged
merged 2 commits into from
Mar 23, 2018
Merged

Helpful error message on few arguments #49

merged 2 commits into from
Mar 23, 2018

Conversation

arpit1997
Copy link
Contributor

Resolves #45

@codecov
Copy link

codecov bot commented Mar 22, 2018 •
edited

Codecov Report

Merging #49 into master will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   85.03%   85.89%   +0.86%     
==========================================
  Files          14       14              
  Lines         695      695              
==========================================
+ Hits          591      597       +6     
+ Misses         88       84       -4     
+ Partials       16       14       -2
Impacted Files Coverage Δ
extractors/bilibili.go 89.39% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e029da...c702690. Read the comment docs.

iawia002
iawia002 requested changes Mar 23, 2018
View reviewed changes
Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little problem, by the way, you can use '[ci skip]' in the next commit

main.go Outdated
@@ -31,7 +32,9 @@ func main() {
return
}
if len(args) < 1 {
fmt.Println("error")
fmt.Printf("Too few arguments \n")
fmt.Printf("Usage of %s: \n", os.Args[0])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tabs to indent and align with the above

@arpit1997
Copy link
Contributor Author

@iawia002 fixed the indentation. that was a typo by mistake

@chinanf-boy chinanf-boy mentioned this pull request Mar 23, 2018
Closed
@iawia002 iawia002 merged commit 4315740 into iawia002:master Mar 23, 2018
@iawia002
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iawia002 iawia002 iawia002 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arpit1997 @iawia002