fix issue #791 #782 #796
Merged
fix issue #791 #782 #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iawia002
reviewed
Sep 30, 2020
extractors/bilibili/bilibili.go
Outdated
Comment on lines
281
to
282
| fmt.Printf("Warning: Multi thread download is no longer supported by BiliBili, use single thread instead.\n") | ||
| fmt.Printf("Thread Number: %d\n", option.ThreadNumber) |
There was a problem hiding this comment.
Basically LGTM, but I think this is unnecessary
There was a problem hiding this comment.
I agree that line 282 is unnessary. But I still insist that it may be confusing for users to see -n parameter not working as expected, so printing a warning is beneficial.
But overall you are the owner, so you can make the final decision.
iawia002
reviewed
Sep 30, 2020
Co-authored-by: Xinzhao Xu <z2d@jifangcheng.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
下载bilibili playlist时，annie默认采用多线程。在Bilibili更新风控策略后，此类多线程下载被视为爬虫，从而导致用户ip被加入黑名单。ip加入黑名单期间，用户访问目标视频将返回http 412错误。
本次修改思路为：在下载bilibili视频时强制使用单线程。在解析bilibili视频时，强制忽略-n 参数，将下载线程数置为1。经测试，可以有效避免返回http 412错误。