Skip to content

Latest commit

 

History

History
54 lines (36 loc) · 2.77 KB

CONTRIBUTING.md

File metadata and controls

54 lines (36 loc) · 2.77 KB
Raw

Contributions

Contributor License Agreements

Before to propose a patch please fill out either the individual or corporate Contributor License Agreement (CLA).

  • If you are an individual writing original source code and you're sure you own the intellectual property, then you'll need to sign an individual CLA.
  • If you work for a company that wants to allow you to contribute your work, then you'll need to sign a corporate CLA.

Follow either of the two links above to access the appropriate CLA and instructions for how to sign and return it. Once we receive it, we'll be able to accept your pull requests.

Contributing A Patch

The code is generated with the jsinterop generator and is based on the extern files defined in the closure-compiler project. They are several ways to improve the generated code:

  1. Submit an issue describing your proposed change to the repo in question.

  2. The repo owner will respond to your issue.

  3. Fork the desired repo.

  4. Implement and test your change:

  5. Open a pull request in the right repository.

Smooth development experience.

This repository is strongly linked to two other repositories: - the jsinterop generator project - the closure-compiler project

For a smooth developer experience with Bazel, we recommend you to check-in locally both projects and modify the elemental2 WORSPACE in order to refer directly to your local repositories. For that purpose, add the following lines at the beginning of the WORKSPACE file (after the workspace definition):

workspace(name = "com_google_elemental2")

# add the code below just after the workspace definition

new_local_repository(
    name = "com_google_closure_compiler",
    path = "/path/to/closure-compiler/repo",
    build_file = "jscomp.BUILD",
)

local_repository(
    name = "com_google_jsinterop_generator",
    path = "/path/to/jsinterop-generator/repo",
)

Be sure to replace /path/to/closure-compiler/repo and /path/to/jsinterop-generator/repo accordingly.

You can now implement local modifications in both project and ask Bazel to build elemental2 with those modifications.