Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI margins & borders to make them more comfortable #66

Merged
merged 2 commits into from
Aug 1, 2021
Merged

Fix GUI margins & borders to make them more comfortable #66

merged 2 commits into from
Aug 1, 2021

Conversation

ewancg
Copy link
Contributor

@ewancg ewancg commented Aug 1, 2021

Before:
image

After:
image

  • Menu bar no longer sticks out because of (potentially) improperly assigned border
  • Group boxes are no longer squeezed up against each other
  • Spacing within settings widgets is no longer inconsistent

@ibancg
Copy link
Owner

ibancg commented Aug 1, 2021

Hi, thanks for the contribution, all the UI changes look fine to me.

I will be happy to merge those, but I get two new GTK warnings:

(lingot:476803): Gtk-CRITICAL **: 22:20:24.738: gtk_paned_set_position: assertion 'GTK_IS_PANED (paned)' failed
(lingot:476803): Gtk-CRITICAL **: 22:20:24.738: gtk_paned_set_position: assertion 'GTK_IS_PANED (paned)' failed

It seems this undoes previous commit 031e619, where I was introducing resizable panels with GtkPaned, now gone. Was this intentional?, it's like if you started your contribution from version 1.1.0 instead of 1.1.1.

@ewancg
Copy link
Contributor Author

ewancg commented Aug 1, 2021

I didn't mean to overstep any recent commits. I was working on the latest release, solely because it had the automake files handy. After I was finished I just copied the glade files over into my fork, which was on the latest commit. I was using 1.1.1, though. Remedial commits coming shortly.

@ibancg ibancg merged commit b575f9b into ibancg:master Aug 1, 2021
@ibancg
Copy link
Owner

ibancg commented Aug 1, 2021

True, 1.1.1 was the last one released, not 1.0.0. All fine now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants