Handle boolean attributes like hiccup does. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything I could do to make this more attractive to merge? It fixes a rather uncomfortable incompatibility with Hiccup. |
ibdknox
added a commit
that referenced
this pull request
Sep 7, 2012
Handle boolean attributes like hiccup does.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiccup treats attributes with boolean values specially: it drops attributes like {:foo false}, and rewrites attributes like {:foo true} to foo="foo". This pullreq changes crate to behave the same way.
This is necessary for things like select-options to work correctly, as they are implemented with the expectation of this special behavior.
Note that this pullreq supersedes the more short-sighted #9 , which fixed the symptom in select-options, instead of the underlying problem.