Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against nil contentType #51

Merged
merged 1 commit into from Aug 6, 2014
Merged

guard against nil contentType #51

merged 1 commit into from Aug 6, 2014

Conversation

bostonaholic
Copy link
Contributor

  • As of ClojureScript
    0.0-2280 (clojure/clojurescript@774d458),
    re-find will throw a TypeError for nil. If the caller of
    jayq.core/preprocess-request does not pass in a contentType, we
    should not be associng :data into the request.

- As of ClojureScript
  0.0-2280 (clojure/clojurescript@774d458),
  `re-find` will throw a TypeError for nil. If the caller of
  `jayq.core/preprocess-request` does not pass in a `contentType`, we
  should not be associng `:data` into the request.
frankhale added a commit that referenced this pull request Aug 6, 2014
guard against nil contentType
@frankhale frankhale merged commit 9376602 into ibdknox:master Aug 6, 2014
@frankhale
Copy link
Collaborator

Thank you!

@bostonaholic
Copy link
Contributor Author

Awesome, thanks for the merge.

Is there a timeline for a new release?

@frankhale
Copy link
Collaborator

The only thing going on right now is merging pull requests. I've just
created a new release 2.5.2 to reflect the last two recent code merges.
Thank you for your pull request. If you have any ideas on how to make this
library better or code you want to merge in please let me know.

On Wed, Aug 6, 2014 at 12:53 PM, Matthew Boston notifications@github.com
wrote:

Awesome, thanks for the merge.

Is there a timeline for a new release?


Reply to this email directly or view it on GitHub
#51 (comment).

@bostonaholic
Copy link
Contributor Author

Great, thanks! I'll keep my eye on clojars for the update.

@frankhale
Copy link
Collaborator

I'll release to clojars later on tonight.

On Wed, Aug 6, 2014 at 1:05 PM, Matthew Boston notifications@github.com
wrote:

Great, thanks! I'll keep my eye on clojars for the update.


Reply to this email directly or view it on GitHub
#51 (comment).

@bostonaholic
Copy link
Contributor Author

👍

@frankhale
Copy link
Collaborator

I just published 2.5.2 to Clojars.

On Wed, Aug 6, 2014 at 1:20 PM, Matthew Boston notifications@github.com
wrote:

[image: 👍]


Reply to this email directly or view it on GitHub
#51 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants