IBX-2603: Content Tree actions: followup for code standards (#404)

ibexa · Apr 28, 2022 · 6f47fbb · 6f47fbb
1 parent 725066b
commit 6f47fbb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/bundle/Resources/public/js/scripts/sidebar/btn/location.create.js b/src/bundle/Resources/public/js/scripts/sidebar/btn/location.create.js
@@ -6,9 +6,9 @@
     }
 
     createActions.forEach((container) => {
-        const btns = container.querySelectorAll('.form-check [type="radio"]');
+        const radioInputs = container.querySelectorAll('.form-check [type="radio"]');
         const form = container.querySelector('form');
 
-        btns.forEach((btn) => btn.addEventListener('change', () => form.submit(), false));
+        radioInputs.forEach((radioInput) => radioInput.addEventListener('change', () => form.submit(), false));
     });
 })(window, window.document);
diff --git a/src/bundle/Resources/public/js/scripts/sidebar/extra.actions.js b/src/bundle/Resources/public/js/scripts/sidebar/extra.actions.js
@@ -24,28 +24,26 @@
 
         removeBackdrop();
     };
-    const toggleExtraActionsWidget = (dataset) => {
-        const actions = doc.querySelector(`.ibexa-extra-actions[data-actions="${dataset.actions}"]`);
+    const toggleExtraActionsWidget = (widgetData) => {
+        const actions = doc.querySelector(`.ibexa-extra-actions[data-actions="${widgetData.actions}"]`);
 
-        if (dataset.validate && !parseInt(dataset.isFormValid, 10)) {
+        if (widgetData.validate && !parseInt(widgetData.isFormValid, 10)) {
             return;
         }
 
         const isHidden = haveHiddenPart(actions);
-        const methodNameContainer = isHidden ? 'remove' : 'add';
-        const methodNameMenu = isHidden ? 'add' : 'remove';
-        const focusElement = actions.querySelector(dataset.focusElement);
+        const focusElement = actions.querySelector(widgetData.focusElement);
         const detectClickOutside = (event) => {
             if (event.target.classList.contains('ibexa-backdrop')) {
                 closeExtraActions(actions);
                 doc.body.removeEventListener('click', detectClickOutside, false);
             }
         };
 
-        actions.classList[methodNameContainer](CLASS_HIDDEN);
+        actions.classList.toggle(CLASS_HIDDEN, !isHidden);
 
         if (menu) {
-            menu.classList[methodNameMenu](CLASS_EXPANDED);
+            menu.classList.toggle(CLASS_EXPANDED, isHidden);
         }
 
         if (!actions.classList.contains(CLASS_HIDDEN)) {