Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7158: As an Editor, I'd like to have shortcut for search focus #1006

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Nov 23, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7158
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barbaragr barbaragr self-requested a review November 24, 2023 11:25
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Double displayed hint:
Preconditions: several content items in app for search results

Steps:

  1. Go to Dashboard, type name of the content item
  2. Click View all results

Actual result: Second hint with shortcut is displayed above to Sort by relevance dropdown

Expected result: No hints.
Screenshot 2023-11-24 at 16 08 31

II Another search loose its focus:

Steps:

  1. Go to Recent activity
  2. Click inside Recent activity search
  3. Try to type some question marks or anything starting with question mark.

Actual result: User can type only one question mark inside the local search, then it looses its focus, because global search gains its focus. It affects every page with local and global search.

loosing_focus.mov

What is more for UDW and Invite members modal local search looses it focus and because global search is covered user doesn't know what is happening. For Invite members modal appears close button tooltip.

loosing_focus2.mov

@barbaragr
Copy link

III Double displayed hint for Content groups:

Go to Product Catalog, Customer Groups
Screenshot 2023-11-27 at 07 05 05

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@dew326 dew326 merged commit ed07c31 into main Dec 6, 2023
23 checks passed
@dew326 dew326 deleted the shortcut-search branch December 6, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet