Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7294: Gracefully handle missing user's thumbnail image #1031

Merged
merged 1 commit into from
Dec 19, 2023
Merged

IBX-7294: Gracefully handle missing user's thumbnail image #1031

merged 1 commit into from
Dec 19, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Dec 5, 2023 •
edited by mikadamczyk
Loading

Question Answer
Tickets IBX-7294
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Similar issue in the Product catalog: https://github.com/ibexa/product-catalog/pull/1109

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 added Bug Something isn't working Ready for review labels Dec 5, 2023
@barw4 barw4 requested a review from a team December 5, 2023 14:56
@barw4 barw4 self-assigned this Dec 5, 2023
@mikadamczyk
Copy link
Contributor

@barw4 rebase should fix errors from PHPStan

@barw4
Copy link
Contributor Author

barw4 commented Dec 6, 2023

@mikadamczyk PR is for 4.5 though as the same issue exists in this branch. Can we do a backport to 4.5 as well?

@barw4 barw4 force-pushed the ibx-7138-gracefully-handle-missing-user-thumbnail branch from eda9dd0 to 9d26531 Compare December 6, 2023 18:57
@barw4
Copy link
Contributor Author

barw4 commented Dec 6, 2023

Rebased

@mikadamczyk mikadamczyk requested a review from a team December 8, 2023 09:06
@alongosz alongosz requested a review from a team December 8, 2023 09:38
@micszo micszo self-assigned this Dec 19, 2023
@mikadamczyk mikadamczyk force-pushed the ibx-7138-gracefully-handle-missing-user-thumbnail branch from 9d26531 to 5043c40 Compare December 19, 2023 08:11
@micszo micszo mentioned this pull request Dec 19, 2023
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

micszo
micszo approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with sanities.

@micszo micszo removed their assignment Dec 19, 2023
@adamwojs adamwojs merged commit 9f3a7fd into 4.5 Dec 19, 2023
16 checks passed
@adamwojs adamwojs deleted the ibx-7138-gracefully-handle-missing-user-thumbnail branch December 19, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@barw4 barw4

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@barw4 @mikadamczyk @alongosz @micszo @ViniTou @konradoboza @adamwojs @Nattfarinn @ciastektk @dew326