IBX-7367: Added config provider for image picker #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Dec 13, 2023
alongosz
approved these changes
Dec 13, 2023
Nattfarinn
approved these changes
Dec 13, 2023
ciastektk
force-pushed
the
ibx-7367-added-config-provider-for-image-picker
branch
from
e7ce610
to
f6a1302
Compare
|
ViniTou
approved these changes
Dec 22, 2023
kisztof
approved these changes
Dec 22, 2023
micszo
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/ibexa/core/blob/main/data/mysql/cleandata.sql#L50
This is required by image picker to be able to run UDW with correct settings and search by correct field definition and content type identifier.
Currently values for field definition and KeywordTermAggregation are hardcoded.
https://github.com/ibexa/image-picker/blob/main/src/bundle/ui-dev/src/modules/image-picker/components/items-view/items.view.js#L198-L202
https://github.com/ibexa/admin-ui/blob/main/src/bundle/ui-dev/src/modules/universal-discovery/hooks/useSearchByQueryFetch.js#L73
Checklist:
$ composer fix-cs)