Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7461: [Site context] Hover and clicked state on Site context #1089

Merged
merged 2 commits into from
Jan 12, 2024
Merged

IBX-7461: [Site context] Hover and clicked state on Site context #1089

merged 2 commits into from
Jan 12, 2024

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Jan 3, 2024 •
edited by micszo
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7523
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

With https://github.com/ibexa/site-context/pull/26

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@micszo micszo self-assigned this Jan 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo mentioned this pull request Jan 12, 2024
Closed
micszo
micszo approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New chevron animation looks great and is applied globally!

@micszo micszo removed their assignment Jan 12, 2024
@dew326 dew326 merged commit c4907f7 into main Jan 12, 2024
15 of 18 checks passed
@dew326 dew326 deleted the IBX-7461-hover-sa-switcher branch January 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GrabowskiM @dew326 @micszo @lucasOsti @Gengar-i