Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7465: Updated Noto Sans fonts #1090

Merged
merged 1 commit into from
Jan 29, 2024
Merged

IBX-7465: Updated Noto Sans fonts #1090

merged 1 commit into from
Jan 29, 2024

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Jan 3, 2024 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7465
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no

Updated Noto Sans fonts using downloads from
https://fonts.google.com/noto/specimen/Noto+Sans

(Fixes issue notofonts/noto-source#125)

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@reithor reithor marked this pull request as ready for review January 3, 2024 15:19
@reithor
Copy link
Contributor Author

reithor commented Jan 3, 2024 •
edited
Loading

Hi @GrabowskiM ,
the original files added with #321 were significantly smaller (~50% of the new ones).
Do you remember where you got the files from ?
From https://notofonts.github.io/#latin-greek-cyrillic ?

@reithor reithor requested a review from dew326 January 3, 2024 15:21
@tomaszszopinski
Copy link
Contributor

Hello, I have applied the patch i have copied example text from JIRA to article CT (rich text field) and this is the result (left is chrome, right is safari):
1090_1
It seems that 'i' char is still not displayed correctly.

@reithor
Copy link
Contributor Author

reithor commented Jan 25, 2024 •
edited
Loading

Hi @tomaszszopinski

  • did you run php bin/console assets:install after applying the patch ?
  • browser cache is cleared ?

@tomaszszopinski
Copy link
Contributor

Yes, did all that and i still get:
Zrzut ekranu 2024-01-26 o 11 49 18

@adamwojs adamwojs changed the title IBX-7465: fixed font 'Noto Sans' IBX-7465: Fxed font 'Noto Sans' Jan 27, 2024
@adamwojs adamwojs changed the title IBX-7465: Fxed font 'Noto Sans' IBX-7465: Updated Noto Sans fonts Jan 27, 2024
tomaszszopinski
tomaszszopinski approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.5

@adamwojs adamwojs merged commit abe1dd0 into 4.5 Jan 29, 2024
22 checks passed
@adamwojs adamwojs deleted the ibx-7465_fixed_font_noto_sans branch January 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet