Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7637: [User settings] Enabled/Disabled labels should be in upper case #1176

Merged
merged 3 commits into from
Feb 26, 2024
Merged

IBX-7637: [User settings] Enabled/Disabled labels should be in upper case #1176

merged 3 commits into from
Feb 26, 2024

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7637
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@ViniTou
Copy link
Contributor

ViniTou commented Feb 19, 2024

@GrabowskiM
However it seems those labels needs to be also adjusted in behat tests:

Ibexa\Behat\Browser\Exception\ElementNotFoundException: Could not find element named: 'disabled'.

@GrabowskiM GrabowskiM force-pushed the IBX-7637-enabled-disabled-uppercase branch from 51a8cc0 to 4562917 Compare February 20, 2024 13:43
@barbaragr barbaragr self-assigned this Feb 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 40c6937 into main Feb 26, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7637-enabled-disabled-uppercase branch February 26, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@dew326 dew326 dew326 approved these changes

@ViniTou ViniTou ViniTou approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@barbaragr barbaragr barbaragr approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@barbaragr barbaragr

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@GrabowskiM @ViniTou @mikadamczyk @dew326 @lucasOsti @barbaragr @Gengar-i @Nattfarinn @ciastektk