Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7645: Added secondary-dark btn #1177

Merged
merged 2 commits into from
Mar 5, 2024
Merged

IBX-7645: Added secondary-dark btn #1177

merged 2 commits into from
Mar 5, 2024

Conversation

Gengar-i
Copy link
Contributor

Question Answer
JIRA issue IBX-7645
Type improvement
Target version v4.6
BC breaks no
Doc needed no

Added secondary-dark btn

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Gengar-i Gengar-i requested a review from dew326 February 20, 2024 11:06
@Gengar-i Gengar-i force-pushed the ibx-7645-added-secondary-dark-btn branch from efac2da to 10673c2 Compare March 4, 2024 09:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@juskora juskora mentioned this pull request Mar 4, 2024
Closed
@juskora
Copy link
Contributor

juskora commented Mar 5, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@dew326 dew326 merged commit dde567b into main Mar 5, 2024
22 checks passed
@dew326 dew326 deleted the ibx-7645-added-secondary-dark-btn branch March 5, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@juskora juskora juskora approved these changes

Assignees

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Gengar-i @juskora @GrabowskiM @tischsoic @dew326 @lucasOsti