IBX-6905: Changing Country in Corporate Account form removes current data without any warning #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
approved these changes
Feb 21, 2024
Gengar-i
approved these changes
Feb 21, 2024
GrabowskiM
commented
Feb 21, 2024
| @@ -0,0 +1,22 @@ | |||
| @mixin spinner($size, $line-size, $color: $ibexa-color-info) { | |||
There was a problem hiding this comment.
That's backported from 4.6 so I left it as it is with hope there will be no conflicts, but I started to wonder if we should treat ibexa-color-info as default for spinner color - as I check it now on 4.6, we have 3 usages of info, 4 (or even 5 with this issue) of primary and one for white.
Do we want to leave it as it is for BC and counter-intuitive, or we'd rather to change it to primary? (which would require more work with upmerge, as these three places where we use info (as default) would need to be adjusted.
dew326
approved these changes
Feb 26, 2024
lucasOsti
approved these changes
Feb 26, 2024
tischsoic
approved these changes
Feb 27, 2024
GrabowskiM
force-pushed
the
IBX-6905-address-loader
branch
from
98fe4cc
to
40c6937
Compare
GrabowskiM
force-pushed
the
IBX-6905-address-loader
branch
from
40c6937
to
308f09d
Compare
GrabowskiM
force-pushed
the
IBX-6905-address-loader
branch
from
308f09d
to
6acd33a
Compare
…data without any warning
GrabowskiM
force-pushed
the
IBX-6905-address-loader
branch
from
6acd33a
to
24f0f15
Compare
|
|
QA Approved on Ibexa DXP Commerce 4.5-dev. |
juskora
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5Backporting spinner mixin for fieldtype-address fix
Checklist:
@ibexa/engineering).