Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7085: Missing text for empty screens #1185

Merged
merged 2 commits into from
Mar 11, 2024
Merged

IBX-7085: Missing text for empty screens #1185

merged 2 commits into from
Mar 11, 2024

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7085
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@katarzynazawada katarzynazawada mentioned this pull request Mar 8, 2024
Closed
katarzynazawada
katarzynazawada requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong color of text in Sub-items list
Screenshot 2024-03-08 at 11 00 39

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 28a9fb8 into main Mar 11, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7085-missing-texts branch March 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@GrabowskiM @mikadamczyk @tischsoic @dew326 @lucasOsti @katarzynazawada @Gengar-i @Nattfarinn @ciastektk @ViniTou