IBX-8188: Fix breadcrumbs hidden menu (not opening) #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Apr 22, 2024
tischsoic
commented
| 🎫 Issue | IBX-8188 |
|---|
tischsoic
commented
Apr 22, 2024
| @@ -41,6 +42,10 @@ const Breadcrumbs = () => { | |||
| const toggleHiddenListVisible = useCallback(() => { | |||
| setHiddenListVisible(!hiddenListVisible); | |||
| }, [setHiddenListVisible, hiddenListVisible]); | |||
| const handleTogglerClick = (event) => { | |||
| event.stopPropagation(); | |||
There was a problem hiding this comment.
Note: we need to stop this propagation because otherwise it may be caught again in hideHiddenMenuOnClickOutside. Also, note that this event is a react event, which may have a different propagation than a standard DOM event.
Gengar-i
approved these changes
Apr 22, 2024
dew326
approved these changes
Apr 22, 2024
GrabowskiM
approved these changes
Apr 24, 2024
| const hideHiddenMenuOnClickOutside = (event) => { | ||
| const { target } = event; | ||
|
|
||
| if (hiddenListWrapperRef.current?.contains(target) ?? false) { |
There was a problem hiding this comment.
in theory ?? false is unnecessary, I think? as if it does not exist, it's undefined, which is falsy as well
There was a problem hiding this comment.
I wanted to be explicit here so that it will be easier to understand when reading.
tischsoic
force-pushed
the
IBX-8188-fix-breadcrumbs-hidden-menu
branch
from
c524805
to
fcde668
Compare
|
barbaragr
approved these changes
Apr 25, 2024
|
Merged up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.