IBX-2277: [Taxonomy] As a user, I want to change language context in Taxonomy Tree #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Feb 9, 2022
tischsoic
reviewed
Feb 11, 2022
| @@ -0,0 +1,17 @@ | |||
| (function(global, doc, ibexa) { | |||
| const set = (domElement, instance) => { | |||
There was a problem hiding this comment.
I'm not sure, but I would probably prefer more verbose names e.g. setInstance etc. given these are functions and not object methods. WDYT? 🤔
| const set = (domElement, instance) => { | ||
| domElement.ibexaInstance = instance; | ||
| } | ||
| const get = (domElement) => { |
There was a problem hiding this comment.
Not sure whether we need to implement it right now, but... now it is not possible to check whether the given dom element has instance assigned without catching the error and checking its message.
Why not just return undefined when there is not instance assigned?
I think the guidance here may be get method from Map which does just that.
ref. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/get
| @@ -6,6 +6,8 @@ | |||
| container: dropdownContainer, | |||
| }); | |||
|
|
|||
| dropdownContainer.instance = dropdown; | |||
There was a problem hiding this comment.
Why you are not using helper here?
tischsoic
approved these changes
Feb 14, 2022
tischsoic
approved these changes
Feb 14, 2022
dew326
approved these changes
Feb 15, 2022
GrabowskiM
force-pushed
the
IBX-2277-taxonomy-as-a-user-i-want-to-change-language-context-in-taxonomy-tree
branch
from
b72a9d9
to
01efa4c
Compare
GrabowskiM
force-pushed
the
IBX-2277-taxonomy-as-a-user-i-want-to-change-language-context-in-taxonomy-tree
branch
from
01efa4c
to
f73b730
Compare
bogusez
approved these changes
Mar 2, 2022
dew326
deleted the
IBX-2277-taxonomy-as-a-user-i-want-to-change-language-context-in-taxonomy-tree
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)