IBX-2278: Added spinner to loading location meta data #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
reviewed
Feb 10, 2022
| const creationDateLabel = Translator.trans(/*@Desc("Created")*/ 'meta_preview.creation_date', {}, 'universal_discovery_widget'); | ||
| const translationsLabel = Translator.trans(/*@Desc("Translations")*/ 'meta_preview.translations', {}, 'universal_discovery_widget'); | ||
| const renderMetaPreviewLoadingSpinner = () => { | ||
| if (locationData && locationData.location && locationData.version) { |
There was a problem hiding this comment.
I'm not sure if this check is sufficient. If nothing is selected and there is no loading the spinner will be visible?
GrabowskiM
reviewed
Feb 10, 2022
| </> | ||
| ); | ||
| }; | ||
| const lastModifiedLabel = Translator.trans(/*@Desc("Last modified")*/ 'meta_preview.last_modified', {}, 'universal_discovery_widget'); |
There was a problem hiding this comment.
Why are these translation moved below lines where they're used?
GrabowskiM
requested changes
Feb 14, 2022
| ); | ||
| }; | ||
| const renderMetaPreview = () => { | ||
| if (!locationData || !locationData.location || !locationData.version) { |
There was a problem hiding this comment.
maybe some additional func or move it above, as you used this kind of statement before (line 102)
GrabowskiM
approved these changes
Feb 16, 2022
tischsoic
approved these changes
Feb 18, 2022
| const lastModifiedLabel = Translator.trans(/*@Desc("Last modified")*/ 'meta_preview.last_modified', {}, 'universal_discovery_widget'); | ||
| const creationDateLabel = Translator.trans(/*@Desc("Created")*/ 'meta_preview.creation_date', {}, 'universal_discovery_widget'); | ||
| const translationsLabel = Translator.trans(/*@Desc("Translations")*/ 'meta_preview.translations', {}, 'universal_discovery_widget'); | ||
| const renderMetaPreviewLoadingSpinner = () => { |
There was a problem hiding this comment.
Given this is inside ContentMetaPreview it can be shortened:
Suggested change
| const renderMetaPreviewLoadingSpinner = () => { | |
| const renderLoadingSpinner = () => { |
dew326
approved these changes
Feb 18, 2022
lucasOsti
force-pushed
the
IBX-2278-Added-spinner-to-meta-preview-UDW
branch
from
12c38d1
to
d09612b
Compare
katarzynazawada
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)