IBX-1007: [Admin UI] As a developer I want to have js code style used in code #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Feb 23, 2022
Comment on lines
3
to
4
| const { hasAsset } = toggleForm.dataset; | ||
| const { hasUniqueAsset } = toggleForm.dataset; |
There was a problem hiding this comment.
Suggested change
| const { hasAsset } = toggleForm.dataset; | |
| const { hasUniqueAsset } = toggleForm.dataset; | |
| const { hasAsset, hasUniqueAsset } = toggleForm.dataset; |
Comment on lines
4
to
7
| const { contentDraftEditUrl } = event.currentTarget.dataset; | ||
| const { versionHasConflictUrl } = event.currentTarget.dataset; | ||
| const { contentId } = event.currentTarget.dataset; | ||
| const { languageCode } = event.currentTarget.dataset; |
There was a problem hiding this comment.
Suggested change
| const { contentDraftEditUrl } = event.currentTarget.dataset; | |
| const { versionHasConflictUrl } = event.currentTarget.dataset; | |
| const { contentId } = event.currentTarget.dataset; | |
| const { languageCode } = event.currentTarget.dataset; | |
| const { contentDraftEditUrl, versionHasConflictUrl, contentId, languageCode } = event.currentTarget.dataset; |
lucasOsti
requested changes
Feb 23, 2022
| onConfirm: confirmHandler, | ||
| onCancel: cancelHandler, | ||
| }); | ||
| const mergedConfig = { ...config, onConfirm: confirmHandler, |
There was a problem hiding this comment.
const mergedConfig = {
...config,
onConfirm: confirmHandler,
onCancel: cancelHandler,
};
?? :)
| @@ -30,15 +29,13 @@ | |||
| btn.addEventListener( | |||
| 'click', | |||
| () => { | |||
| const actions = doc.querySelector(`.ibexa-extra-actions[data-actions="${btn.dataset.actions}"]`);if (btn.dataset.validate && !parseInt(btn.dataset.isFormValid, 10)) { | |||
| const actions = doc.querySelector(`.ibexa-extra-actions[data-actions="${btn.dataset.actions}"]`); if (btn.dataset.validate && !parseInt(btn.dataset.isFormValid, 10)) { | |||
There was a problem hiding this comment.
Suggested change
| const actions = doc.querySelector(`.ibexa-extra-actions[data-actions="${btn.dataset.actions}"]`); if (btn.dataset.validate && !parseInt(btn.dataset.isFormValid, 10)) { | |
| const actions = doc.querySelector(`.ibexa-extra-actions[data-actions="${btn.dataset.actions}"]`); | |
| if (btn.dataset.validate && !parseInt(btn.dataset.isFormValid, 10)) { |
| 'X-CSRF-Token': token, | ||
| }), | ||
| headers: { ...HEADERS_CREATE_VIEW, 'X-Siteaccess': siteaccess, | ||
| 'X-CSRF-Token': token }, |
There was a problem hiding this comment.
headers: {
...HEADERS_CREATE_VIEW,
"X-Siteaccess": siteaccess,
"X-CSRF-Token": token,
},
?
GrabowskiM
force-pushed
the
IBX-1007-linter
branch
from
75f99f1
to
ffe8839
Compare
GrabowskiM
force-pushed
the
IBX-1007-linter
branch
from
ffe8839
to
14864e4
Compare
lucasOsti
approved these changes
Feb 28, 2022
dew326
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
ibexa/eslint-config-ibexa#5
Checklist:
$ composer fix-cs)