Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2565: Main menu - text outside popup when too long #368

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-2565
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Screenshot 2022-03-21 at 10 30 02

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@@ -142,6 +142,12 @@
width: calculateRem(250px);
top: calculateRem(12px);
left: calculateRem(48px);

&__item-content {
overflow:hidden;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
overflow:hidden;
overflow: hidden;


&__item-content {
overflow:hidden;
white-space:nowrap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
white-space:nowrap;
white-space: nowrap;

Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes from Darek

@lucasOsti lucasOsti changed the base branch from main to 4.0 March 23, 2022 08:40
@dew326 dew326 merged commit 13aa8d7 into ibexa:4.0 Mar 23, 2022
@dew326
Copy link
Contributor

dew326 commented Mar 23, 2022

@lucasOsti you can merge up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants