Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2961: Refactored Extension to rely on Encore Configuration Dumper #471

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jun 14, 2022

Question Answer
JIRA issue IBX-2961
Requires ibexa/core#120
Type improvement
Target Ibexa version v4.1+
BC breaks no

This PR aligns AdminUi with the changes done in ibexa/core#120 for ibexa/fieldtype-richtext#46

Doc

It is worth to update "Importing assets from a bundle" page, stating that now it's possible to place Ibexa Webpack Encore configuration in the project top-level directory encore. Applies to:

  • ibexa.config.js
  • ibexa.config.manager.js

And also:

  • ibexa.webpack.custom.config.js
  • ibexa.config.setup.js

but for the latter two I don't see any mention in the doc.

QA

  1. Sanity/regression check regarding custom configuration mentioned in the doc and for those 4 files.
  2. Sanity/regression check of OE (e.g. by creating an Article)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage (generic coverage in core).
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review

@alongosz alongosz force-pushed the ibx-2961-refactor-to-use-config-dumper branch from 57297ee to ea724c0 Compare June 22, 2022 08:14
@alongosz alongosz merged commit 29c7905 into 4.1 Jun 22, 2022
@alongosz alongosz deleted the ibx-2961-refactor-to-use-config-dumper branch June 22, 2022 08:46
@DominikaK DominikaK removed the Doc needed The changes require some documentation label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants