IBX-3826: [Navigation menu] Field groups navigation menu cannot select 2nd choice #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Sep 14, 2022
tischsoic
reviewed
Sep 15, 2022
Comment on lines
23
to
25
| const sections = sectionGroup.querySelectorAll('.ibexa-edit-content__secondary-section'); | ||
|
|
||
| return sections ? [...sections].at(-1) : null; |
There was a problem hiding this comment.
sections will always be true
Suggested change
| const sections = sectionGroup.querySelectorAll('.ibexa-edit-content__secondary-section'); | |
| return sections ? [...sections].at(-1) : null; | |
| return [...sections].at(-1); |
There was a problem hiding this comment.
also, I think it is too early for .at, unfortunately. 😞
https://caniuse.com/mdn-javascript_builtins_array_at
GrabowskiM
force-pushed
the
IBX-3826-navigation-menu-field-groups-navigation-menu-cannot-select-2nd-choice
branch
from
0ee9eb8
to
770fbdb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tischsoic
approved these changes
Sep 15, 2022
tomaszszopinski
approved these changes
Sep 15, 2022
mikadamczyk
approved these changes
Sep 15, 2022
mikadamczyk
deleted the
IBX-3826-navigation-menu-field-groups-navigation-menu-cannot-select-2nd-choice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)