IBX-3682: AdminUI extension points to be used by Corporate Account #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
approved these changes
Oct 11, 2022
GrabowskiM
reviewed
Oct 11, 2022
| @@ -4,7 +4,7 @@ | |||
| <meta charset="UTF-8" /> | |||
| <meta name="CSRF-Token" content="{{ csrf_token('authenticate') }}" /> | |||
| <meta name="SiteAccess" content="{{ app.request.get('siteaccess').name }}" /> | |||
| <meta name="UserId" content="{{ ibexa_admin_ui_config.user.user.id }}" /> | |||
| <meta name="UserId" content="{{ ibexa_admin_ui_config.user.user.id|default() }}" /> | |||
There was a problem hiding this comment.
this looks little strange, that in twig for admin panel there can be no authenticated user, but I guess it has sth to do with corporate account and it's necessary evil
There was a problem hiding this comment.
Wouldnt that be anonymous user id anyway?
@Nattfarinn
There was a problem hiding this comment.
Nope. user is null.
GrabowskiM
approved these changes
Oct 11, 2022
dew326
approved these changes
Oct 11, 2022
Steveb-p
approved these changes
Oct 11, 2022
src/bundle/Resources/views/themes/admin/content/edit_macros.html.twig
Outdated
Show resolved
Hide resolved
adamwojs
reviewed
Oct 11, 2022
src/bundle/Resources/views/themes/admin/content/edit_macros.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/edit_macros.html.twig
Outdated
Show resolved
Hide resolved
lucasOsti
approved these changes
Oct 11, 2022
mikadamczyk
approved these changes
Oct 11, 2022
webhdx
approved these changes
Oct 11, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
lucasOsti
approved these changes
Oct 11, 2022
ViniTou
approved these changes
Oct 12, 2022
This was referenced Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: https://github.com/ibexa/corporate-account/pull/95