Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4028: Set default background of ibexa-card to transparent #607

Merged
merged 1 commit into from
Oct 19, 2022
Merged

IBX-4028: Set default background of ibexa-card to transparent #607

merged 1 commit into from
Oct 19, 2022

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-4028
Bug fix? yes/no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

@tischsoic tischsoic self-assigned this Oct 14, 2022
tischsoic
tischsoic commented Oct 14, 2022
View reviewed changes
src/bundle/Resources/public/scss/_card.scss
@@ -1,6 +1,6 @@
.ibexa-card {
border: none;
background-color: $ibexa-color-white;
background-color: transparent;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine given there is .ibexa-card--light with background: $ibexa-color-white;.

@tischsoic tischsoic force-pushed the IBX-4028-ibexa-card-should-be-transparent-by-default branch from b1b7567 to bc5d7c3 Compare October 19, 2022 08:22
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326 dew326 merged commit 79a5593 into 4.2 Oct 19, 2022
@dew326 dew326 deleted the IBX-4028-ibexa-card-should-be-transparent-by-default branch October 19, 2022 11:36
@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@tischsoic tischsoic

@dew326 dew326

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tischsoic @GrabowskiM @dew326 @lucasOsti @katarzynazawada @Gengar-i