IBX-4328: Hover on icons preview switcher #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Nov 23, 2022
Gengar-i
approved these changes
Nov 23, 2022
dew326
approved these changes
Nov 23, 2022
tischsoic
approved these changes
Nov 23, 2022
GrabowskiM
force-pushed
the
IBX-4328-preview-icons-switcher-hover
branch
from
1f6c5a5
to
28c1b9a
Compare
katarzynazawada
requested changes
Dec 1, 2022
There was a problem hiding this comment.
In Page Builder hover on icon preview still has wrong color, see https://recordit.co/MmVbNljGNx
katarzynazawada
requested changes
Dec 5, 2022
There was a problem hiding this comment.
There is a difference between hover on selected icon in PB and admin-ui
https://recordit.co/en6Nu5oyd1
https://recordit.co/LIDd8MtPFJ
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)