Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5013: Removed mergin from header in objectrelation fieldtype #694

Merged
merged 1 commit into from
Feb 9, 2023
Merged

IBX-5013: Removed mergin from header in objectrelation fieldtype #694

merged 1 commit into from
Feb 9, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Feb 3, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5013
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 self-assigned this Feb 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jwibexa jwibexa self-assigned this Feb 8, 2023
jwibexa
jwibexa approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and validated:
Ibexa Experience Version 4.3.2
FF and Chrome

@dew326 dew326 merged commit 15fae13 into 4.3 Feb 9, 2023
@dew326 dew326 deleted the objectrelation-margin branch February 9, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@jwibexa jwibexa jwibexa approved these changes

@Gengar-i Gengar-i Awaiting requested review from Gengar-i

Assignees

@dew326 dew326

@jwibexa jwibexa

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dew326 @GrabowskiM @tischsoic @lucasOsti @jwibexa