IBX-4445: Option to add last column in tables as sticky #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
approved these changes
Feb 10, 2023
dew326
approved these changes
Feb 15, 2023
lucasOsti
approved these changes
Feb 16, 2023
tischsoic
requested changes
Feb 17, 2023
| @@ -97,6 +97,28 @@ | |||
|
|
|||
| tablesCheckboxesChangeListeners.delete(table); | |||
| }; | |||
| let prevShouldShowRightColumnShadow = false; | |||
There was a problem hiding this comment.
This variable should be one per table, not one for all tables.
But, actually, do we needshouldShowRightColumnShadow !== prevShouldShowRightColumnShadow check? In case we care about performance, I would go for requestAnimationFrame.
GrabowskiM
force-pushed
the
IBX-4445-table-last-column-sticky
branch
from
c137d4f
to
6d1305b
Compare
Gengar-i
approved these changes
Feb 22, 2023
dew326
approved these changes
Feb 23, 2023
lucasOsti
approved these changes
Feb 23, 2023
tomaszszopinski
approved these changes
Feb 28, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mikadamczyk
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)