IBX-5121: Streamlined SiteaccessResolverInterface #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ibx-5121-streamlined-sa-resolver-interface
branch
from
bb94ae7
to
091fb94
Compare
webhdx
approved these changes
Mar 15, 2023
adamwojs
reviewed
Mar 24, 2023
| 'name' | ||
| ); | ||
| } | ||
|
|
||
| public function getSiteAccessesList(): array |
There was a problem hiding this comment.
Nitpick: phpdoc could be more specific about type of returned value
There was a problem hiding this comment.
It is in interface.
Steveb-p
reviewed
Mar 24, 2023
ViniTou
force-pushed
the
ibx-5121-streamlined-sa-resolver-interface
branch
from
d05fba1
to
cbac63c
Compare
adamwojs
approved these changes
Mar 28, 2023
ViniTou
force-pushed
the
ibx-5121-streamlined-sa-resolver-interface
branch
from
cbac63c
to
c50bd39
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomaszszopinski
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of changes, I moved
\Ibexa\PageBuilder\Siteaccess\SiteaccessService::resolveSiteAccessForContentinto\Ibexa\AdminUi\Siteaccess\SiteaccessResolverInterfaceas it seems that is a proper place for it. As additional cleanup, I had deprecated\Ibexa\AdminUi\Siteaccess\SiteaccessResolverInterface::getSiteaccessesForLocationasgetSiteAccessesListForLocationdoes basically the same thing, and the naming is quite confusing - same thing was done forgetSiteaccessesmethod.Checklist:
$ composer fix-cs)