IBX-5412: Removed parseInt from selectedItem.dataset.id #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested review from
Gengar-i,
GrabowskiM,
lucasOsti,
tischsoic and
dew326
lucasOsti
approved these changes
Mar 30, 2023
dew326
approved these changes
Mar 30, 2023
GrabowskiM
approved these changes
Mar 30, 2023
Gengar-i
approved these changes
Mar 30, 2023
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
|
After checking by QA, one more problem was found, I corrected the data-id setting to the correct path for the subtree filter instead of setting "selected-subtree" to clear properly the input value that controls the filter |
mateuszdebinski
requested review from
dew326,
GrabowskiM,
lucasOsti and
Gengar-i
GrabowskiM
approved these changes
Mar 31, 2023
lucasOsti
approved these changes
Apr 3, 2023
Gengar-i
approved these changes
Apr 3, 2023
dew326
approved these changes
Apr 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)