Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5361: Use NotCompromisedPassword constraint #750

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

glye
Copy link
Contributor

@glye glye commented Mar 30, 2023

Question Answer
Tickets IBX-5361
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

See description in the companion PR ibexa/core#221. That PR adds the feature that this one adds admin UI for. The feature is disabled by default, for BC.

Documentation
The password rules page would need documentation for this feature.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Attribution
  • Ready for Code Review

Screenshot
screenshot

@glye glye added Doc needed The changes require some documentation Ready for review and removed Work in progress Ready for review labels Mar 30, 2023
@ibexa ibexa deleted a comment from sonarcloud bot Mar 30, 2023
@glye glye requested a review from a team March 30, 2023 15:15
@glye glye added the Feature New feature request label Mar 30, 2023
@glye glye requested a review from webhdx April 3, 2023 13:15
@glye glye requested a review from webhdx April 17, 2023 07:28
@alongosz alongosz force-pushed the ibx5361-use_NotCompromisedPassword_constraint branch from 2c2e591 to 7301d61 Compare April 18, 2023 11:26
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx merged commit 022ec42 into main Apr 18, 2023
14 checks passed
@glye glye deleted the ibx5361-use_NotCompromisedPassword_constraint branch April 18, 2023 11:58
@DominikaK DominikaK removed the Doc needed The changes require some documentation label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants