Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6001: Added cast items array to String #843

Merged
merged 3 commits into from
Jul 27, 2023
Merged

IBX-6001: Added cast items array to String #843

merged 3 commits into from
Jul 27, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets IBX-6001
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jul 20, 2023
@mateuszdebinski mateuszdebinski requested a review from a team July 20, 2023 11:43
@mateuszdebinski mateuszdebinski self-assigned this Jul 20, 2023
@mateuszdebinski mateuszdebinski changed the base branch from main to 4.5 July 20, 2023 11:52
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jwibexa jwibexa self-assigned this Jul 27, 2023
jwibexa
jwibexa approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and validated on 4.5 experience FF and chrome

@ViniTou ViniTou merged commit 5ce24e8 into 4.5 Jul 27, 2023
14 checks passed
@ViniTou ViniTou deleted the IBX-6001_cant_remove_tag_from_content branch July 27, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@jwibexa jwibexa jwibexa approved these changes

Assignees

@dew326 dew326

@mateuszdebinski mateuszdebinski

@jwibexa jwibexa

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mateuszdebinski @GrabowskiM @tischsoic @dew326 @lucasOsti @Gengar-i @jwibexa @ViniTou