Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6279: Simplify actions in create and edit modes #862

Merged
merged 40 commits into from
Sep 26, 2023

Conversation

@tischsoic tischsoic self-assigned this Aug 5, 2023
@tischsoic tischsoic force-pushed the simplify-action-in-edit-mode branch 3 times, most recently from 451ff5e to 3dad1cd Compare August 24, 2023 13:42
@tischsoic tischsoic force-pushed the simplify-action-in-edit-mode branch 3 times, most recently from 64e342b to 7c70f76 Compare September 6, 2023 19:47
@tischsoic tischsoic changed the base branch from main to multilevel-popup-menu September 7, 2023 08:46
@tischsoic tischsoic force-pushed the simplify-action-in-edit-mode branch 5 times, most recently from 8f9ca6d to 1cb97dd Compare September 11, 2023 06:43
@tischsoic
Copy link
Contributor Author

Note: these phpstan errors are related to content-forms changes

------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/lib/Form/Processor/ContentEditFormProcessor.php                                                                                                  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  32     Method Ibexa\AdminUi\Form\Processor\ContentEditFormProcessor::getSubscribedEvents() should return array<string, array<int|string, array<int|string,  
         int|string>|int|string>|string> but returns array<int|string, array<int, int|string>>.                                                               
  33     Access to undefined constant Ibexa\ContentForms\Event\ContentFormEvents::CONTENT_SAVE_DRAFT_AND_CLOSE.                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 

@tischsoic tischsoic marked this pull request as ready for review September 11, 2023 12:41
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
26.0% 26.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dew326 dew326 merged commit ceba506 into multilevel-popup-menu Sep 26, 2023
9 of 14 checks passed
@dew326 dew326 deleted the simplify-action-in-edit-mode branch September 26, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet