Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Behat tests #891

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fixed Behat tests #891

merged 1 commit into from
Aug 31, 2023

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Aug 31, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6314
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0
Needs ibexa/system-info#44

This PR is a result of changing the tab name to Product in system-info package https://github.com/ibexa/system-info/pull/44/files#diff-3e96dfcf9b3d195658a34706c41dd70943c731a874f92bf5f749cb5dff6c8f0fR3

https://github.com/ibexa/system-info/actions/runs/6035157816/job/16374967649?pr=44

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk requested review from mnocon and a team August 31, 2023 08:12
@mikadamczyk mikadamczyk self-assigned this Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

konradoboza
konradoboza reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having a hard time tracking down the origins of this tab renaming in the first place, could you please provide it?

@konradoboza konradoboza requested a review from a team August 31, 2023 09:02
mnocon
mnocon approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikadamczyk mikadamczyk merged commit d60f1d5 into main Aug 31, 2023
17 of 18 checks passed
@mikadamczyk mikadamczyk deleted the fix-translations-in-system-info branch August 31, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikadamczyk @mnocon @konradoboza @Nattfarinn @ciastektk @ViniTou