Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6492: Keyboard support for redo and undo #903

Merged
merged 4 commits into from
Sep 22, 2023
Merged

IBX-6492: Keyboard support for redo and undo #903

merged 4 commits into from
Sep 22, 2023

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Sep 8, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6492
Type improvement
Target Ibexa version v4.6
BC breaks no

Keyboard support for redo and undo

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran yarn test
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@Gengar-i Gengar-i force-pushed the ibx-6492-keyboard-support-red-undo branch from 861135e to edd06d4 Compare September 13, 2023 07:40
@GrabowskiM GrabowskiM force-pushed the ibx-6492-keyboard-support-red-undo branch from edbd6ec to 1e9cfbd Compare September 19, 2023 10:06
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GrabowskiM GrabowskiM self-assigned this Sep 19, 2023
tomaszszopinski
tomaszszopinski approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6. commerce on win/mac/ubuntu.

@dew326 dew326 merged commit 059f630 into main Sep 22, 2023
14 checks passed
@dew326 dew326 deleted the ibx-6492-keyboard-support-red-undo branch September 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@GrabowskiM GrabowskiM

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gengar-i @GrabowskiM @dew326 @lucasOsti @tomaszszopinski