Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6881: Upgrade chart.js to 4.4.0 #961

Merged
merged 4 commits into from
Nov 16, 2023
Merged

IBX-6881: Upgrade chart.js to 4.4.0 #961

merged 4 commits into from
Nov 16, 2023

Conversation

Gengar-i
Copy link
Contributor

Question Answer
Tickets IBX-6881
Bug fix? no
New feature? no
BC breaks? possible
Tests pass? yes
Doc needed? yes
License GPL-2.0

Upgrade chart.js to 4.4.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

GrabowskiM
GrabowskiM approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except Darek comment and eslint

@Gengar-i Gengar-i requested a review from dew326 November 2, 2023 12:06
@micszo micszo self-assigned this Nov 16, 2023
@micszo micszo mentioned this pull request Nov 16, 2023
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

micszo
micszo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.6.x-dev.

@micszo micszo removed their assignment Nov 16, 2023
@adamwojs adamwojs merged commit 54a8734 into main Nov 16, 2023
23 checks passed
@adamwojs adamwojs deleted the IBX-6881 branch November 16, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Gengar-i @GrabowskiM @dew326 @micszo @lucasOsti @adamwojs @mikadamczyk @Nattfarinn @ciastektk @ViniTou