Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6937: Used NumberType field to set max image size in ImageFormMapper #966

Merged

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Oct 31, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6937
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? yes/no
Related to ibexa/core#291
License GPL-2.0

This PR changes form type field maxSize from Integer to Number that allows to use float values for max file size setting.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team November 7, 2023 07:28
@ciastektk ciastektk force-pushed the ibx-6937-used-number-type-field-to-set-image-max-size branch from 01b7b6f to 32c6dd2 Compare November 30, 2023 13:26
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@ciastektk ciastektk merged commit 354f7e6 into main Dec 6, 2023
22 of 23 checks passed
@ciastektk ciastektk deleted the ibx-6937-used-number-type-field-to-set-image-max-size branch December 6, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants