Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6750: [Smart mode] As the User I want to display tabs in Content items in different order by default #976

Merged
merged 2 commits into from
Nov 20, 2023
Merged

IBX-6750: [Smart mode] As the User I want to display tabs in Content items in different order by default #976

merged 2 commits into from
Nov 20, 2023

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Nov 6, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6750
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@kisztof kisztof changed the base branch from main to IBX-6839-authors-tab November 6, 2023 12:39
@kisztof kisztof changed the title [Smart mode] As the User I want to display tabs in Content items in different order by default IBX-6750: [Smart mode] As the User I want to display tabs in Content items in different order by default Nov 6, 2023
@adamwojs
Copy link
Member

adamwojs commented Nov 16, 2023 •
edited
Loading

@kisztof You have syntax error in committed code:

Syntax error, unexpected T_STRING, expecting ';' on line 53

See CI report for more informations

adamwojs
adamwojs requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in comment above

@kisztof kisztof force-pushed the IBX-6750-tabs-order branch 2 times, most recently from 7fb4667 to 655c4e3 Compare November 20, 2023 15:00
@webhdx webhdx requested a review from adamwojs November 20, 2023 15:10
@adamwojs adamwojs requested a review from a team November 20, 2023 15:19
Base automatically changed from IBX-6839-authors-tab to main November 20, 2023 15:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@webhdx webhdx merged commit 6717148 into main Nov 20, 2023
23 checks passed
@webhdx webhdx deleted the IBX-6750-tabs-order branch November 20, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx webhdx approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kisztof @adamwojs @webhdx @mikadamczyk @Nattfarinn @ciastektk @dew326 @ViniTou