Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6957: Moved UDW endpoints to REST API #989

Merged
merged 12 commits into from
Nov 21, 2023
Merged

IBX-6957: Moved UDW endpoints to REST API #989

merged 12 commits into from
Nov 21, 2023

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Nov 16, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6957
Bug fix? no
New feature? no
BC breaks? yes/no
Tests pass? yes/no
Doc needed? yes/no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ciastektk ciastektk force-pushed the ibx-6957-moved-udw-endpoints-to-rest-api branch from 5d34931 to 5ca492b Compare November 16, 2023 15:16
@webhdx webhdx requested a review from a team November 21, 2023 09:29
konradoboza
konradoboza reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, all the visited keys coming from generator should be uppercase, but this can be done as a follow-up to save frontend adjustments.

src/lib/UniversalDiscovery/UniversalDiscoveryProvider.php Outdated Show resolved Hide resolved
src/lib/UniversalDiscovery/UniversalDiscoveryProvider.php Outdated Show resolved Hide resolved
src/lib/UniversalDiscovery/UniversalDiscoveryProvider.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team November 21, 2023 10:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alongosz
alongosz approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 overall after a brief look. Smaller issues can be resolved later.

src/lib/REST/Value/UniversalDiscovery/LocationListData.php
* }
* >
*/
final class LocationListData extends Value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use here \Ibexa\Rest\Server\Values\LocationList instead of new object.

@alongosz alongosz requested a review from a team November 21, 2023 11:52
@webhdx webhdx merged commit 9cb0938 into main Nov 21, 2023
23 checks passed
@webhdx webhdx deleted the ibx-6957-moved-udw-endpoints-to-rest-api branch November 21, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ciastektk @alongosz @konradoboza @mikadamczyk @Nattfarinn @webhdx @dew326 @ViniTou