IBX-6230: Added validation of CSS selectors #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
force-pushed
the
add-css-validator
branch
from
7769736
to
808553e
Compare
mnocon
force-pushed
the
add-css-validator
branch
from
808553e
to
e62804b
Compare
This was referenced Aug 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mnocon
changed the title
mnocon
requested review from
micszo,
katarzynazawada,
tomaszszopinski,
bogusez and
jwibexa
bogusez
approved these changes
Aug 21, 2023
micszo
approved these changes
Aug 21, 2023
tomaszszopinski
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-6230
This PR makes sure that it's not possible to use selectors that are not fully supported by the Symfony CssSelector component.
See: https://symfony.com/doc/current/components/css_selector.html#limitations-of-the-cssselector-component
After this PR is merged it will be impossible to use a selector that is not supported - currently they can be used, but they are incorrectly translated into XPath and result in hard to debug issues.
Error:
Status: