Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Browser Tests to use GH App token #201

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Enable Browser Tests to use GH App token #201

merged 1 commit into from
Jan 20, 2023

Conversation

ibexa-yuna
Copy link
Contributor

@ibexa-yuna ibexa-yuna commented Jan 19, 2023 •
edited

Question Answer
JIRA issue Ad-Hoc
Type improvement
Target Ibexa version v4.x+
BC breaks no
Doc needed no

Since ibexa/gh-workflows#30 is now merged and this feature is generally available, we can now migrate workflow to a new authentication method.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@ibexa-yuna ibexa-yuna changed the title Enabled Browser Tests to use GH App token Enable Browser Tests to use GH App token Jan 19, 2023
mnocon
mnocon approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This was referenced Jan 20, 2023
Merged
Merged
Merged
@ibexa-yuna ibexa-yuna marked this pull request as ready for review January 20, 2023 11:19
@mnocon mnocon merged commit 26e1f70 into 4.3 Jan 20, 2023
@ibexa-yuna ibexa-yuna deleted the browser-tests-token branch January 20, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibexa-yuna @mnocon