Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5569: Replaced changelog generator workflow with reusable #251

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

ibexa-yuna
Copy link
Contributor

Question Answer
JIRA issue IBX-5569
Type improvement
Target Ibexa version v4.5
BC breaks no
Doc needed no

This will replace the hardcoded changelog generator workflow with the one stored in a gh-workflows repository, allowing to maintain workflow easier, since there will be only 1 place to make changes.

This PR has to be merged after ibexa/gh-workflows#38

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review.

.github/workflows/release_tag.yml Show resolved Hide resolved
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More removed than added lines is what I like to see 👍

@ibexa-yuna
Copy link
Contributor Author

Final run:

https://github.com/ibexa-yuna/commerce/actions/runs/4752409980
This time no deprecation notices too.

@ibexa-yuna
Copy link
Contributor Author

Linking rest of PRs:

ibexa/experience#168
ibexa/content#78
ibexa/oss#93

@ibexa-yuna
Copy link
Contributor Author

ibexa/gh-workflows#38 is now merged.

@ibexa-yuna ibexa-yuna changed the base branch from master to 3.3 April 27, 2023 08:30
@alongosz alongosz merged commit 154bfc6 into 3.3 Apr 27, 2023
@alongosz alongosz deleted the IBX-5569 branch April 27, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants